fix(l1): clean up precompiles.rs for better readability #4801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles.rs by:\n- Merging import statements from both branches\n- Keeping structured precompile definitions from main\n- Preserving BLS12-381 and BLAKE2F constants from both branches\n- Using cleaner is_precompile and execute_precompile implementations
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reorganizes the precompiles.rs file by adding section headers and documentation comments to improve code readability and maintainability. The changes focus on better organization without altering functionality.
Key changes:
- Added descriptive section headers using comment blocks to separate different constant groups
- Moved imports to a more logical position at the top of the file
- Added inline documentation for constants explaining their purpose and usage
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| #[expect(clippy::as_conversions, clippy::indexing_slicing)] | ||
| #[expect(clippy::as_conversions)] |
There was a problem hiding this comment.
The removal of clippy::indexing_slicing from the expect attribute may cause clippy warnings if the function contains indexing operations. Verify that no indexing operations exist in execute_precompile, or add the lint suppression back if they do.
Suggested change
| #[expect(clippy::as_conversions)] | |
| #[expect(clippy::as_conversions, clippy::indexing_slicing)] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reopen #4565 cc @mpaulucci